This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Removes bucketName fields from Protocol #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign wlan0 |
wlan0
approved these changes
May 7, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishchow, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
NicolasT
added a commit
to scality/cosi-driver-sample
that referenced
this pull request
May 10, 2021
Recent changes in the API removed the `endpoint` and `bucketName` fields from the `S3Protocol` structure (in the CRD). This change reflects the API change so CI succeeds again. See: kubernetes-retired/container-object-storage-interface-api#41
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
May 29, 2024
Update README.md
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
add identity server to sample-driver
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
Update README.md
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
add identity server to sample-driver
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
Create CHANGELOG-0.1.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38
Fixes: #36
This PR aims to remove the bucketName fields in the protocol in favor of the bucketID field in the
Bucket.spec. We also remove the API-approved annotation.